feat: attendance/#673#679
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive user attendance system, including daily attendance tracking, streak management, and a reward system. It adds new database entities, repositories, services, and a scheduler to manage daily resets and record initialization. Feedback focuses on scalability concerns regarding the broadcast mechanism, a bug preventing new users from attending on their first day, the need for bulk updates when resetting streaks, and missing notification logic for rewards.
Finefinee
approved these changes
Apr 14, 2026
redjungi09
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
0 0 0-5,7-23 * * *KST)BroadcastAttendanceBoardService추가 — 전체 활성 유저 조회 후ATTENDANCE/DATA_CHANGED소켓 이벤트 발송AttendanceRefetchNotifier.notifyAttendanceBoard()메서드 추가GET /api/users/me/attendance/weeklySwagger 문서 보완weekNumber,currentStreak필드 추가관련 이슈
Closes #673
추가 컨텍스트
클라이언트는 두 가지 시점에
GET /api/users/me/attendance/weekly를 호출합니다.ATTENDANCE/DATA_CHANGED이벤트 수신 시 — 실시간 갱신서버는 06:00에 streak 초기화 및 레코드 생성을 수행하고, 이후 매 정시마다 전체 유저에게 소켓 알림을 보내 늦게 앱을 켠 유저도 출석판을 확인할 수 있도록 합니다.